Skip to content

Incorrect color coding #164

Description

2019-04-23_15-21-26

Issue Type: Bug

Enter an interpolated string like

"git:https//$($env:UserName)@bitbucket.tds.td.com"

Expect that only the $(...) expression is blue, but i see the bitbucket... also in blue, expect that to be in light brown like the first part of the string

Extension version: 1.12.1
VS Code version: Code 1.33.1 (51b0b28134d51361cf996d2f0a1c698247aeabd8, 2019-04-11T08:27:14.102Z)
OS version: Windows_NT x64 10.0.16299

System Info
Item Value
CPUs Intel(R) Core(TM) i5-8350U CPU @ 1.70GHz (8 x 1896)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: enabled
surface_synchronization: enabled_on
video_decode: enabled
webgl: enabled
webgl2: enabled
Memory (System) 31.84GB (15.74GB free)
Process Argv
Screen Reader no
VM 0%

Activity

rjmholt commented on Apr 23, 2019

@rjmholt

Thanks for reporting this issue Gerald Britton (@gbritton1). The grammar for PowerShell syntax highlighting is maintained in the Editor Syntax repo

msftrncs commented on Apr 24, 2019

@msftrncs
Contributor

This has been reported before as #149, and mentioned in #137 (regarding rewriting the variable logic), if not earlier.

PR #155 and #156 do not exhibit this error.

Nick James (@omniomi), I never noticed this before, I long ago cleaned this up while experimenting, but #doubleQuotedString includes both #variableNoProperty and #variable. Also, #variableNoProperty possesses a match pattern that would include some variations of @scope:variable.

I will try to shortly post a PR for these apparent mistakes/oversights.

added a commit that references this issue on Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions