fix: add zh-CN mapping for Qwen-MT translator - #1202
Open
Morningstar202604 wants to merge 1 commit into
Open
Morningstar202604 wants to merge 1 commit into
Morningstar202604 wants to merge 1 commit into
Conversation
Qwen-MT's lang_mapping had no entry for zh-CN, so translating with zh-CN as the source or target language raised a KeyError. Map it to Chinese along with zh and zh-TW.
Morningstar202604
force-pushed
the
fix/qwenmt-zh-cn-mapping
branch
from
September 29, 2026 19:00
4a74c73 to
c4787a1
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Qwen-MT’s
lang_mappinghad no entry forzh-CN, so translating with zh-CN as the source or target language raised aKeyError: "zh-CN". Added the missing mapping to Chinese, next to the existingzhandzh-TWentries, plus a unit test covering the language codes.Issues
Verification
pytest test/test_translator.pypasses (10 tests)