Repository navigation
Fix transform_each subscription exception handling - #2319
Merged
ericniebler merged 7 commits intoOct 10, 2026
Merged
ericniebler merged 7 commits into
ericniebler merged 7 commits into
Conversation
ericniebler
reviewed
Oct 9, 2026
Collaborator
|
/ok to test c478e01 |
Collaborator
|
/ok to test f4cf9b4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix exception handling in
transform_eachsubscription.Why
A child subscription can throw. The wrapper could terminate instead of passing the exception to the caller.
Implementation
Include the child subscription in the
noexceptcheck. Add regression cases for throwingbegin()andend().