Skip to content

Fix lvalue arguments in coroutine cleanup helpers - #2316

Merged
ericniebler merged 3 commits into
NVIDIA:mainfrom
fallintoplace:fix/coroutine-cleanup-lvalue-arguments
Oct 9, 2026
Merged

ericniebler merged 3 commits into
NVIDIA:mainfrom
fallintoplace:fix/coroutine-cleanup-lvalue-arguments

Conversation

@fallintoplace

Copy link
Copy Markdown
Contributor

What

  • Allow lvalue arguments in coroutine cleanup helpers.

Why

  • at_coroutine_exit(action, value) fails to compile. Its wrapper returns __task<int&>, but the coroutine creates __task<int>.

Implementation

  • Decay argument types in both cleanup wrapper return types.

@copy-pr-bot

copy-pr-bot Bot commented Oct 8, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ericniebler

Copy link
Copy Markdown
Collaborator

/ok to test 5654a84

@ericniebler
ericniebler merged commit d722269 into NVIDIA:main Oct 9, 2026
39 checks passed
@ericniebler

Copy link
Copy Markdown
Collaborator

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants