Conversation
…to 12.9 - cuLogsRegisterCallback, cuLogsUnregisterCallback, cuLogsCurrent, cuLogsDumpToFile, cuLogsDumpToMemory: fix cuGetProcAddress_v2 version - Other minor generator output updates (owner field, formatting)
github-actions
Bot
added
the
cuda.bindings
I agree. This PR only wants the changes in driver_linux.pyx an driver_windows.pyx, and the number of lines is supporsed to be small. |
#2953 was merged. General remark: it can be really useful to have xref: cybind !<number> in the PR description. Otherwise it can be quite a bit of detective work later to match against the cybind state. (I've been there many times.) |
mdboom
left a comment
mdboom
left a comment
There was a problem hiding this comment.
LGTM.
This will also need a backport to the 12.9.x branch.
mdboom
left a comment
mdboom
left a comment
There was a problem hiding this comment.
Let's add a regression test -- if it's too hard to actually call these functions, at least confirm that the functions don't raise a FunctionNotFoundError.
This branch has not been deployed
4 participants
Summary
Closes #2979
Regenerated
cuda_bindingsdriver bindings to correctcuLogs*functions' introduced version.
Key fix
cuLogs*functions were incorrectly loaded viacuGetProcAddress_v2with version
12080(CUDA 12.8). They were introduced in CUDA 12.9,so the correct version is
12090.Affected functions:
cuLogsRegisterCallbackcuLogsUnregisterCallbackcuLogsCurrentcuLogsDumpToFilecuLogsDumpToMemoryAdditional changes
Also includes accumulated cybind generator updates since the last regeneration:
driver.pxd: added_ownerfield to Cython struct wrapper classesdriver.pyx: minor formatting cleanup (removed redundantpassstatements and blank lines in
__init__methods)cydriver.pxd: trailing newline fixFiles changed
All files are auto-generated by cybind — do not edit manually.