Skip to content

chore(ci): close stale issues after 14 additional days - #3985

Open
purp wants to merge 1 commit into
NVIDIA:mainfrom
purp:chore/2401-close-stale-issues/purp
Open

purp wants to merge 1 commit into
NVIDIA:mainfrom
purp:chore/2401-close-stale-issues/purp

Conversation

@purp

@purp purp commented Sep 30, 2026

Copy link
Copy Markdown
Collaborator

Summary

Close issues after 14 additional inactive days following the existing 14-day stale warning. Merge after the linked-work protection in #3190.

Related Issue

Closes #2401

Changes

  • Enable issue closure and align its messages with the 14-day close window.
  • Remove the false closure promise from PR messages while keeping PR closure disabled.
  • Document the issue and PR policies in CONTRIBUTING.md.

Testing

  • mise run pre-commit passes.
  • Parsed workflow YAML and verified issue 14 + 14, PR marking only, close reason, and message consistency.
  • mise run ci fails in the unchanged network test proxy::tests::mediated_connect_keeps_workload_bytes_read_with_the_synthesized_header: upstream request timeout. Running that test alone reproduces the same timeout.
  • Unit and sandbox E2E tests are not applicable to these configuration and documentation changes.

Checklist

  • Follows Conventional Commits.
  • Commits are cryptographically signed and signed off (DCO); verified with git verify-commit.
  • Architecture documentation is not affected.

Closes NVIDIA#2401

Signed-off-by: Jim Meyer <jimeyer@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Sep 30, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@purp
purp marked this pull request as ready for review September 30, 2026 20:55

@matthewgrossman matthewgrossman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this do a big-bang one-time stale close of a bunch of tickets? or will it start now?

days-before-issue-close: -1
days-before-pr-stale: 14
days-before-pr-close: -1 # -1 puts this into dry-run mode. Update to 7 to enable closing.
days-before-pr-close: -1

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removes the comment but doesn't change the value? Is that on purpose?

@purp

purp commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator Author

will this do a big-bang one-time stale close of a bunch of tickets? or will it start now?

Big bang. Anything where stale was set more than 14 days ago will get closed.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(ci): close stale issues after 14 additional days

3 participants