Record the user behind each peer, with last-writer-wins registration

[TrueDoctor]

No description provided.

[cubic-dev-ai]

1 issue found across 13 files

Confidence score: 2/5

• registry.rs changes the serialized peer value, so existing v1 Postcard snapshots fail to decode as Registry when open_in reads them. Add a versioned migration or replay fallback before changing the stored format.

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="document/graph-storage/src/registry.rs">

<violation number="1" location="document/graph-storage/src/registry.rs:13">
P1: This changes the serialized value for each registered peer, so existing v1 Postcard snapshots fail to decode as `Registry`; `open_in` reads them directly without a migration or replay fallback. Add a versioned conversion from legacy `UserId` values before changing this persisted shape.</violation>
</file>

<sub>Reply with feedback, questions, or to request a fix.

Re-trigger cubic</sub>

[cubic-dev-ai]

P1: This changes the serialized value for each registered peer, so existing v1 Postcard snapshots fail to decode as Registry; open_in reads them directly without a migration or replay fallback. Add a versioned conversion from legacy UserId values before changing this persisted shape.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At document/graph-storage/src/registry.rs, line 13:

<comment>This changes the serialized value for each registered peer, so existing v1 Postcard snapshots fail to decode as `Registry`; `open_in` reads them directly without a migration or replay fallback. Add a versioned conversion from legacy `UserId` values before changing this persisted shape.</comment>

<file context>
@@ -9,12 +9,18 @@ pub struct Registry {
-	/// Registered by each device's first contribution via `RegistryDelta::RegisterPeer`.
-	pub peer_users: HashMap<PeerId, UserId>,
+	/// Which person each device is, from `RegistryDelta::RegisterPeer`, so undo and authorship scope by person.
+	pub peer_users: HashMap<PeerId, PeerRegistration>,
 	pub attributes: Attributes,
 }
</file context>

[timon-schelling]

Mostly just inconsistent terms used. And I don't get why we need this but I assume that will make more sense once I look at the rest of the stack.