Skip to content

Change summary lang key default value to "the page" #75

Description

@nahuelhds

As stated by @edsu at #74

All that being said, maybe it's best to stick with summary since that is what Readability calls it, and its what is in the model. But I think the default string value should be "the page"?

Activity

  1. edsu commented on May 7, 2020

    @edsu
    Member

    Sorry, my mistake. I think leaving the key as summary works since it matches the data model. I thought that there might be a default value, but it appears that there is not?

  2. nahuelhds commented on May 21, 2020

    @nahuelhds
    ContributorAuthor

    There is no default value because every code I've added to the project was intended for adding features without affecting the current default behavior that the engine already has.

    I'm thinking that we could set a default value if we add a new prop for enable/disable this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions