Skip to content

Fix create_script validator false-positive on constructor invocations #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsarno merged 2 commits into from
Apr 7, 2026
Merged

Fix create_script validator false-positive on constructor invocations #1045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b364834
Fix create_script validator false-positive on constructor invocations
dsarno Apr 7, 2026
ed5323a
Address review: Ordinal comparison, add new-modifier + constructor test
dsarno Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions MCPForUnity/Editor/Tools/ManageScript.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2744,16 +2744,18 @@ private static void CheckDuplicateMethodSignatures(string contents, System.Colle

// Step 3: Match method signatures on code-only text (includes => for expression-bodied)
var methodSigPattern = new Regex(
@"(?:(?:public|private|protected|internal)\s+)?(?:(?:static|virtual|override|abstract|sealed|async|new)\s+)*\S+\s+(\w+)\s*\(([^)]*)\)\s*(?:where\s+\S+\s*:\s*\S+\s*)?(?:[{;]|=>)",
@"(?:(?:public|private|protected|internal)\s+)?(?:(?:static|virtual|override|abstract|sealed|async|new)\s+)*(\S+)\s+(\w+)\s*\(([^)]*)\)\s*(?:where\s+\S+\s*:\s*\S+\s*)?(?:[{;]|=>)",
RegexOptions.Multiline | RegexOptions.CultureInvariant, TimeSpan.FromSeconds(2));
var sigMatches = methodSigPattern.Matches(codeOnly);
var seen = new System.Collections.Generic.Dictionary<string, int>(System.StringComparer.Ordinal);
foreach (Match sm in sigMatches)
{
string methodName = sm.Groups[1].Value;
string returnType = sm.Groups[1].Value;
string methodName = sm.Groups[2].Value;
if (string.Equals(returnType, "new", StringComparison.Ordinal)) continue; // constructor invocation, not a method declaration
if (IsCSharpKeyword(methodName)) continue;
int paramCount = CountTopLevelParams(sm.Groups[2].Value);
string paramTypes = ExtractParamTypes(sm.Groups[2].Value);
int paramCount = CountTopLevelParams(sm.Groups[3].Value);
string paramTypes = ExtractParamTypes(sm.Groups[3].Value);
string containingType = containingTypeArr[sm.Index];
string key = $"{containingType}/{methodName}/{paramCount}/{paramTypes}";
if (seen.TryGetValue(key, out _))
Expand Down
58 changes: 58 additions & 0 deletions TestProjects/UnityMCPTests/Assets/Tests/EditMode/Tools/ManageScriptValidationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,6 +320,64 @@ public void Update()
"C# keywords (if, for, while, etc.) should not be matched as duplicate methods");
}

[Test]
public void DuplicateMethodCheck_ConstructorInvocations_NotFlagged()
{
string code = @"using UnityEngine;
public class Test : MonoBehaviour
{
void Start()
{
GameObject a = new GameObject(""A"");
GameObject b = new GameObject(""B"");
}
}";
var errors = CallValidateScriptSyntaxUnity(code);
Assert.IsFalse(HasDuplicateMethodError(errors),
"Constructor invocations (new Type(...)) should not be flagged as duplicate methods");
}

[Test]
public void DuplicateMethodCheck_MultipleDistinctConstructors_NotFlagged()
{
string code = @"using UnityEngine;
public class Test : MonoBehaviour
{
void Start()
{
var mpb1 = new MaterialPropertyBlock();
var mpb2 = new MaterialPropertyBlock();
var go1 = new GameObject(""A"");
var go2 = new GameObject(""B"");
}
}";
var errors = CallValidateScriptSyntaxUnity(code);
Assert.IsFalse(HasDuplicateMethodError(errors),
"Multiple constructor invocations of different types should not be flagged");
}

[Test]
public void DuplicateMethodCheck_NewModifierWithConstructors_CorrectBehavior()
{
string code = @"using UnityEngine;
public class Base : MonoBehaviour
{
public virtual void Init() { }
}
public class Derived : Base
{
public new void Init() { }
void Start()
{
var a = new GameObject(""A"");
var b = new GameObject(""B"");
}
}";
var errors = CallValidateScriptSyntaxUnity(code);
Assert.IsFalse(HasDuplicateMethodError(errors),
"new modifier on method should not interfere with constructor invocation filtering");
}

[Test]
public void HandleCommand_PathWithCsExtension_StripsFilename()
{
Expand Down