Read a channel cursor with a malformed time as the first page, not a 500 - #640
Merged
davidmckayv merged 2 commits intoOct 2, 2026
Merged
Conversation
Ayush7614
requested review from
MikeRyanDev,
davidmckayv,
guidovizoso,
mxmzb and
tylerslaton
as code owners
September 23, 2026 19:36
Contributor
|
Needs changes before merge:
|
decodeChannelCursor only checked that recency was a string, and the page query casts it with ::timestamptz, so a hand-edited cursor answered 500. A recency that is not the UTC timestamp the encoder writes now reads as the first page, like every other malformed cursor.
davidmckayv
force-pushed
the
fix/channel-people-strict-cursor
branch
from
October 2, 2026 18:38
702d570 to
e7f68cd
Compare
Contributor
|
I narrowed this to the channel bug and force-pushed it to your branch. I dropped the 400s. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A channel cursor's
recencywas only checked to be a string before the page query cast it with::timestamptz, so a corrupted cursor answered 500. It now has to be the UTC timestamp the encoder writes (millisecond or microsecond), or the cursor reads as the first page, like every other malformed cursor.Narrowed by a maintainer from the original version, which turned malformed channel and people cursors into a 400.