Skip to content

Rename deleteHeader() to unsetHttpHeader() #22

Description

@ThomasLandauer

To be consistent with all other header functions: haveHttpHeader() (to which it is the counterpart), seeHttpHeader(), seeHttpHeaderOnce(), etc.

Also in lib-innerbrowser

Activity

  1. ThomasLandauer commented on Oct 3, 2020

    @ThomasLandauer
    MemberAuthor

    Actually, "delete" isn't really the right term here. I'd say: Either unsetHttpHeader(), or (to be consistent with have...) dontHaveHttpHeader()

  2. SamMousa commented on Oct 14, 2020

    @SamMousa
    Contributor

    A PR to fix this could be implemented without breaking BC. Just add an alias for the "wrong" function name and mark it deprecated.
    Move the implementation to the "right" function name.

  3. added a commit that references this issue on Oct 14, 2020
  4. ThomasLandauer commented on Oct 14, 2020

    @ThomasLandauer
    MemberAuthor

    If you merge this, I'll do the same in lib-innerbrowser.

  5. changed the title [-]Rename `deleteHeader()` to `deleteHttpHeader()`[/-] [+]Rename `deleteHeader()` to `unsetHttpHeader()`[/+] on Oct 24, 2020
  6. added a commit that references this issue on Jul 11, 2024
  7. added a commit that references this issue on Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions