Skip to content

✨ Current Line Highlight #34

Description

@austincondiff

Current line needs to be highlighted and current line number is primary text color.

image

Activity

  1. changed the title [-][FEAT] - Current Line Highlight[/-] [+]✨ Current Line Highlight[/+] on Mar 31, 2022
  2. deleted a comment from stale on Jun 1, 2022
  3. removed
    wontfixThis will not be worked on
    on Jun 1, 2022
  4. NakaokaRei commented on Oct 3, 2022

    @NakaokaRei

    @austincondiff
    I want to work on this issue!
    Can you please assign it to me?

  5. austincondiff commented on Oct 3, 2022

    @austincondiff
    CollaboratorAuthor

    Sure thing! One thing to note, the top line is highlighted in this screenshot, so it is working however there are two things that need to happen here.

    1. The highlight needs to extend into the gutter. And the separator needs to be removed.
    2. The line number needs to be more prominent (and other line numbers less prominent).

    image

    We are trying to make it look like this (code folding will come later)...

    image

    One thing to consider is it might have something to do with STTextView so you may need to submit a PR over there as well.

    To get rid of the separator, we need to do the following in STTextViewController.swift...

    - rulerView.separatorColor = theme.invisibles
    + rulerView.drawSeparator = false
  6. moved this from Todo to In Progress in CodeEdit Projecton Oct 3, 2022
  7. NakaokaRei commented on Oct 4, 2022

    @NakaokaRei

    @austincondiff
    Thank you for the advice!
    I will investigate and report back if I have to change STTextView 🙇

  8. NakaokaRei commented on Oct 4, 2022

    @NakaokaRei

    @austincondiff
    As far as you can tell, as you are talking about, it doesn't look like I can tackle this issue without changing STTextView.
    This is difficult for me and I have no prospects for development, so I will remove the assign for now.
    Sorry 🙇

    I think this CodeEdit is a great project and I'll comment as soon as I find an issue I can do myself!

  9. removed their assignment
    on Oct 4, 2022
  10. moved this from In Progress to Todo in CodeEdit Projecton Oct 12, 2022
  11. Eliulm commented on Jan 3, 2023

    @Eliulm
    Contributor

    I am currently finalizing my pull request for the STTextView repository. With that, we can add line highlighting, just like in Xcode.

  12. austincondiff commented on Jan 25, 2023

    @austincondiff
    CollaboratorAuthor

    Closing this as the line highlight has been implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions