Repository navigation
fix(wasm-solana): preserve stake withdrawal recipient - #402
Draft
ralph-bitgo[bot] wants to merge 1 commit into
Draft
ralph-bitgo[bot] wants to merge 1 commit into
ralph-bitgo[bot] wants to merge 1 commit into
Conversation
Expose stake instruction account 1 as toAddress throughout the Rust and TypeScript parser output. Reject unresolved account indices so malformed transactions cannot shift account roles and misstate recipients. Ticket: WCN-1879 Session-Id: 62e2bf02-4569-43fd-8dd6-e3697e48d9d9 Task-Id: db4ad411-11a1-4dff-86b3-b24d0f5731ff
ralph-bitgo
Bot
force-pushed
the
WCN-1879-solana-stake-withdraw-recipient
branch
from
September 24, 2026 01:09
3dddd98 to
6ccbb85
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| data: &data, | ||
| }) { | ||
| ParsedInstruction::StakingWithdraw(params) => params, | ||
| other => panic!("Expected StakingWithdraw, got {other:?}"), |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
toAddressthrough the Rust and TypeScript parser outputs.Why
A destination-free withdrawal representation can hide the account receiving lamports, so approval may not match the recipient bound in the signable transaction.
Test plan
cargo test --manifest-path packages/wasm-solana/Cargo.toml— 54 passed; 1 doctest passed.npm run build --workspace @bitgo/wasm-solana && npm test --workspace @bitgo/wasm-solana— 108 passed.Ticket: WCN-1879