Repository navigation
feat(statics): add bip44CoinType per coin family - #9882
Merged
Merged
Conversation
Contributor
Contributor
|
|
davidkaplanbitgo
previously approved these changes
Oct 2, 2026
mohd-kashif
reviewed
Oct 2, 2026
mohd-kashif
left a comment
Contributor
There was a problem hiding this comment.
Non-blocking suggestions from a code review — all optional, none block merge.
pranishnepal
reviewed
Oct 5, 2026
danielpeng1
force-pushed
the
WCN-2955/statics-bip44-coin-type
branch
from
October 5, 2026 15:40
63de841 to
e86f97a
Compare
danielpeng1
force-pushed
the
WCN-2955/statics-bip44-coin-type
branch
from
October 6, 2026 13:55
e86f97a to
7751d10
Compare
hrishikeshjain
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional
bip44CoinTypeto statics coins, resolved per coin family, and moves the root slot list into statics.bip44CoinTypetoBaseCoin, validated as an integer in[0, 0x7fffffff]BIP44_COIN_TYPES, a table keyed by coin family, so testnets and tokens inherit their parent chain's value (OFC and fiat have none)sdk-coreimports it instead of keeping its own copyTests
Ticket: WCN-2955