Skip to content

feat(statics): add bip44CoinType per coin family - #9882

Merged
pranishnepal merged 1 commit into
masterfrom
WCN-2955/statics-bip44-coin-type
Oct 6, 2026
Merged

pranishnepal merged 1 commit into
masterfrom
WCN-2955/statics-bip44-coin-type

Conversation

@danielpeng1

Copy link
Copy Markdown
Contributor

Adds an optional bip44CoinType to statics coins, resolved per coin family, and moves the root slot list into statics.

  • Add bip44CoinType to BaseCoin, validated as an integer in [0, 0x7fffffff]
  • Add BIP44_COIN_TYPES, a table keyed by coin family, so testnets and tokens inherit their parent chain's value (OFC and fiat have none)
  • Move the root slot list and its ordinals (1–4) into statics; sdk-core imports it instead of keeping its own copy
  • Field stays optional for now; making it required is a follow-up

Tests

  • Field validation (valid, out-of-range, non-integer, boundaries) and family-value default
  • Table values are valid and unique, every coin carries its family's value, testnets and tokens mirror their parent, and every key-holding coin has a value
  • Slot ordinals cover the slot list and run 1–4 in order

Ticket: WCN-2955

@danielpeng1 danielpeng1 self-assigned this Oct 2, 2026
@linear-code

linear-code Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

WCN-2955

@github-actions

github-actions Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

⚠️ Unit tests are failing on Node 26.x (Current release line, non-blocking). This is not an LTS version yet, so it does not block merge, but it signals an incompatibility to fix before Node 26.x becomes LTS.

View run

@danielpeng1
danielpeng1 marked this pull request as ready for review October 2, 2026 16:40
@danielpeng1
danielpeng1 requested review from a team as code owners October 2, 2026 16:40

@mohd-kashif mohd-kashif left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking suggestions from a code review — all optional, none block merge.

Comment thread modules/statics/src/bip44CoinTypes.ts Outdated
Comment thread modules/statics/src/safe.ts
Comment thread modules/statics/src/safe.ts
Comment thread modules/statics/src/base.ts
Comment thread modules/statics/src/base.ts Outdated
Comment thread modules/statics/src/safe.ts
Comment thread modules/statics/src/constants.ts Outdated
@danielpeng1
danielpeng1 force-pushed the WCN-2955/statics-bip44-coin-type branch from e86f97a to 7751d10 Compare October 6, 2026 13:55

@pranishnepal pranishnepal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pranishnepal
pranishnepal merged commit 3964341 into master Oct 6, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants