Repository navigation
feat(sdk-coin-sol): add addFeePayerSignature() - #9848
Draft
ralph-bitgo[bot] wants to merge 1 commit into
Draft
ralph-bitgo[bot] wants to merge 1 commit into
ralph-bitgo[bot] wants to merge 1 commit into
Conversation
Contributor
7 tasks done
Contributor
|
|
ralph-bitgo
Bot
force-pushed
the
CHALO-1652-fee-payer-rewrite-versioned-tx-pt1
branch
from
September 29, 2026 10:56
29f424f to
71b0f65
Compare
Add addFeePayerSignature(publicKey, signature) to Transaction and TransactionBuilder, wrapping the existing addSignature() and rejecting a key that is not account 0 of the message (the fee payer). For versioned transactions account 0 is the first static account key; for legacy transactions web3.js places the fee payer first, so the signature lands in slot 0 on both. Sponsored SOL transactions need the enterprise fee key's signature in slot 0 (CHALO-983); SOL had no such method yet. This is the CHALO-996 dependency surface of the fee-payer rewrite. Ticket: CHALO-1652 Session-Id: c2138ca7-d8a2-46e6-8dd0-e00e22cc44c0 Task-Id: 40c147ec-2821-4dfc-a85f-85bc82e625fa
MohammedRyaan786
force-pushed
the
CHALO-1652-fee-payer-rewrite-versioned-tx-pt1
branch
from
October 7, 2026 06:17
71b0f65 to
a0c5168
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
addFeePayerSignature(publicKey, signature)toTransactionandTransactionBuilderinmodules/sdk-coin-sol.addSignature()and rejects a key that is not account 0 of the message (the fee payer): for a versioned transaction that is the first static account key; for a legacy transaction@solana/web3.jsplaces the fee payer first. On both message kinds the signature lands in slot 0.Why
Test plan
npx mocha test/unit/transaction.ts: the fee-payer signature fills the empty signature slot ofRAW_TX_UNSIGNEDand reproducesRAW_TX_SIGNEDbyte-for-byte; a non-account-0 key and an unbuilt transaction are rejectednpm run lintandtsc --buildclean inmodules/sdk-coin-solTicket: CHALO-1652
Stack
This PR is part 1 of 2 in a stack. Review and merge in order:
addFeePayerSignature()(CHALO-996 dependency surface; base:master) ← you are hereCHALO-1652-fee-payer-rewrite-versioned-tx-pt1)