Skip to content

RequestExtensions.TryGetRequestIdentifier and overall usage of "correlationIdentifier" #85

Description

@norfas

The code from RequestExtensions class quoted below does not make sense, since request?.Headers.TryGetValues(...) call is a "dead code" that has no effect.
And judging by this code I doubt that "correlationIdentifier" is being used to any meaningful purpose in this project.

public static bool TryGetRequestIdentifier(this HttpRequestMessage request, out string requestIdentifier) { request?.Headers.TryGetValues("client-id", out IEnumerable<string> _); requestIdentifier = Guid.NewGuid().ToString(); return true; }

Being used like this:
if (!request.TryGetRequestIdentifier(out correlationIdentifier)) { throw new HttpResponseException(HttpStatusCode.InternalServerError); }

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions